Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release and freezing ML-KEM API? #86

Closed
tomato42 opened this issue Oct 8, 2024 · 5 comments
Closed

Release and freezing ML-KEM API? #86

tomato42 opened this issue Oct 8, 2024 · 5 comments

Comments

@tomato42
Copy link
Collaborator

tomato42 commented Oct 8, 2024

Hey, could we create a new version and push to pypi?
And at the same time, freeze the ML-KEM API?

I'm asking as I have integrated kyber-py into tlslite-ng: tlsfuzzer/tlslite-ng#530 but I'm just using current main for testing, would be nicer if I could use pypi package instead...

@GiacomoPope
Copy link
Owner

somewhat annoyingly someone else uploaded my (old) code to pypi: https://pypi.org/project/kyber-py/ which confuses things a little. As for the API, some people may want to allow using the seeds in various ways rather than the private key itself, which there could be better API for, but I don't know if any of the existing functions will need to change?

@tomato42
Copy link
Collaborator Author

tomato42 commented Oct 8, 2024

I wonder if you can't complain about squatting...

for the API: as the public API I consider basically just the existence of the ML_KEM_512, ML_KEM_768, ML_KEM_1024 objects and then the fact that they have the keygen(), encaps(), and decaps() with the static order and types of inputs/outputs. How the private keys can be serialised and deserialised is secondary, and it can always be handled by adding a keygen_from_seed method

@GiacomoPope
Copy link
Owner

OK, then I'm happy with this concept of freezing. As for pypi, not sure what the best thing to do is, so i'll think about it a bit i guess

@tomato42
Copy link
Collaborator Author

tomato42 commented Oct 8, 2024

even if it's not pushed to pypi, a tagged release would still be nice :)

@GiacomoPope
Copy link
Owner

I have made a version release (https://github.com/GiacomoPope/kyber-py/releases/tag/v1.0) and with your PR #87 I believe this is now closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants