Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreatePollView public #685

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Make CreatePollView public #685

merged 3 commits into from
Dec 9, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Dec 6, 2024

🔗 Issue Link

Related to: 684

🎯 Goal

  • Make CreatePollView public for making it possible to use it standalone

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner December 6, 2024 12:46
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 6, 2024

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.53 MB 7.53 MB 0 KB 🟢

CHANGELOG.md Outdated
Comment on lines 8 to 9
### 🔄 Changed
- Make `CreatePollView` public [#685](https://github.com/GetStream/stream-chat-swiftui/pull/685)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be an addition 🤔 We are exposing a new view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@laevandus laevandus enabled auto-merge (squash) December 9, 2024 07:28
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
42.4% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit 91e4619 into develop Dec 9, 2024
11 of 12 checks passed
@laevandus laevandus deleted the public-create-poll-view branch December 9, 2024 07:54
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants