Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo app changes for pinned and archived channels #683

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Demo app changes for pinned and archived channels #683

merged 3 commits into from
Dec 11, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Dec 6, 2024 •
edited
Loading

🔗 Issue Link

Part of IOS-553

🎯 Goal

  • Replace custom pinning with new backend supported pinning
  • Add archive and unarchive actions
  • Add predefined channel queries and UI for selecting them
    • Initial: all the channels the current user is member of
    • Archived: only archived channels
    • Pinned: only pinned channels
    • Unarchived and sorted by pinned: sort by pinned and exclude archived
  • Grouped custom channel header files in Xcode (therefore, some files were moved)

demo

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner December 6, 2024 07:26
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 6, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.53 MB 7.53 MB 0 KB 🟢

martinmitrevski
martinmitrevski reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we do something in the demo app as well? We have some commented out code in DemoAppSwiftUIApp for pinning, might be good to check it and potentially remove it.

@laevandus laevandus changed the title Use native pinning support for channels [WIP] Use native pinning support for channels Dec 9, 2024
@laevandus laevandus changed the title [WIP] Use native pinning support for channels Demo app changes for pinned and archived channels Dec 9, 2024
nuno-vieira
nuno-vieira approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@laevandus laevandus merged commit 9adc3cf into develop Dec 11, 2024
10 checks passed
@laevandus laevandus deleted the native-channel-pinning branch December 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laevandus @Stream-SDK-Bot @martinmitrevski @nuno-vieira