From 6b0022ee6138b8579ea94497443142e40d351c37 Mon Sep 17 00:00:00 2001 From: Alexey Alter-Pesotskiy Date: Fri, 29 Mar 2024 16:10:25 +0000 Subject: [PATCH] Fix xcmetrics PR detection (#3117) --- fastlane/Fastfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 85bb6ee9b54..93aa9ca6cd8 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -433,7 +433,7 @@ lane :xcmetrics do |options| UI.user_error!("See Firebase error above ☝️") unless firebase_error.to_s.empty? if is_ci - pr_comment_required = ENV.key?('GITHUB_PR_NUM') + pr_comment_required = !ENV['GITHUB_PR_NUM'].to_s.empty? performance_benchmarks[current_branch] = branch_performance UI.message("Performance benchmarks: #{performance_benchmarks}") File.write(performance_path, JSON.pretty_generate(performance_benchmarks))