We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many services use Drupal\common\EventDispatcherTrait because we needed a backwards-compatibility layer between Drupal 8 and 9. See: #3592
Drupal\common\EventDispatcherTrait
Currently, no one should be using Drupal 8, and we don't have Drupal 9 in our testing matrix.
Furthermore, services should be injected into other services, avoiding the \Drupal pattern.
\Drupal
So let's deprecate EventDispatcherTrait and remove its usage in DKAN.
EventDispatcherTrait
@deprecated
event_dispatcher
See that we use EventDispatcherTrait.
Decide that it's not a good pattern.
Fix it.
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Current Behavior
Many services use
Drupal\common\EventDispatcherTrait
because we needed a backwards-compatibility layer between Drupal 8 and 9. See: #3592Currently, no one should be using Drupal 8, and we don't have Drupal 9 in our testing matrix.
Furthermore, services should be injected into other services, avoiding the
\Drupal
pattern.So let's deprecate
EventDispatcherTrait
and remove its usage in DKAN.Expected Behavior
@deprecated
annotation toEventDispatcherTrait
.event_dispatcher
service into classes that currently use the trait.Steps To Reproduce
See that we use EventDispatcherTrait.
Decide that it's not a good pattern.
Fix it.
Relevant log output (optional)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: