Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting PostgreSQL SCHEMA #5

Open
dkastl opened this issue Oct 22, 2021 · 6 comments
Open

Supporting PostgreSQL SCHEMA #5

dkastl opened this issue Oct 22, 2021 · 6 comments
Labels
question Further information is requested

Comments

@dkastl
Copy link
Member

dkastl commented Oct 22, 2021

As far as I understand this would all be done in the public schema, right?

I find it very comfortable to work in a different schema. Would it be possible to enable this? Or would it cause a lot of extra effort?

@dkastl dkastl added the question Further information is requested label Oct 22, 2021
@krashish8
Copy link
Member

Yes, no issues in enabling this. I will just need to prepend the schema name (e.g. scheduler schema) in all the queries.

@dkastl
Copy link
Member Author

dkastl commented Oct 22, 2021

SCHEMA can be sometimes a bit annoying. But it can make database operations also very comfortable, like backups and updates. Could the schema be defined in some environment variables like the database connection?

@krashish8
Copy link
Member

Yes, the schema can be defined in environment variables (will need to check a bit). I think it will need a separate env variable, not sure if it can be done in the database connection variable itself.

@dkastl
Copy link
Member Author

dkastl commented Oct 22, 2021

We could have app.env.example and put app.env on .gitignore to be able to use custom settings without accidentally committing to the repository.

@krashish8
Copy link
Member

Yes, I will do this. There are more such changes required... the application is not complete yet. :)

Apart from completing the coding part, I will need to add the CI/CD (GitHub Actions), documentation (or swagger schema), README, etc. I will also add the unit tests to ensure that everything works fine. Also, later on, we will need to think of whether we should deploy this API and which service to use for this.

Feel free to suggest anything else that is required!

@dkastl
Copy link
Member Author

dkastl commented Oct 22, 2021

Of course. Don't think that you need to fix my issues within a few hours ... I just write them down before I forget about them. And I try to tag them as question if I actually just want to propose them for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants