-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poop Filter Removal #555
Poop Filter Removal #555
Conversation
the poopendarken era is ending |
the pooplightening ... |
can we have a little grimshart.... as a treat? |
tbh i like the filter, but i do agree it'd be better if it were toned down a bit |
actually minor request, can we keep the filter in but just not apply it to folk on spawn? i kinda wanna fuck around w/ it to maybe apply for dark areas or certain antags or smth |
There is some code relating to a CRT filter I removed in my original PR on subterra I suggest you use, if you want to keep the filter. PR it in as an automatically disabled option since some people are deranged and wish to live with a depression filter |
I prefer the grit. Keeping the Grimshart™ vision as a toggleable option (in the same tab-and-vein that the 'CRT' filter occupies) would be very nice. Like what Bear and Kaylexis said, it shouldn't be too hard to make it disabled by default for those who prefer a more clean-and-unassailed view. |
lmfao |
Don't see the need for this. It fits a particular artstyle/aesthetic quite well, sets a certain tone/mood, doesn't detract from anything. And, when combined with the CRT filter it feels, incredibly flavourful like some old fantasy RPG game. |
The reason is that it looks ugly and isn't done well and detracts from everything. Glad to clear this up. |
my opinion on this kinda reversed. the game looks like hot dogshit without the filter because the people that made this code were talentless hacks that couldn't make something look good to save their lives. i'd like if this was a toggle a la crt i think. thanks i love u |
the definition poopdark used by spriters is for an unnecessarily gritty and dark atmosphere placed on sprites and/or a hud filter |
Just merge this shit bruh |
Closing this because I'm about to PR in a toggle that should work. |
Removes the grainy filter effect.
Port of russ-money/subterra#35 by @kaylexis