Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poop Filter Removal #555

Conversation

EvenInDeathIStillServe
Copy link

Removes the grainy filter effect.

Port of russ-money/subterra#35 by @kaylexis

@WatermelonsEverywhere
Copy link

the poopendarken era is ending

@bearrrrrrrr
Copy link

the pooplightening ...

@kittysmooch
Copy link

can we have a little grimshart.... as a treat?

@cdb-is-not-good
Copy link

tbh i like the filter, but i do agree it'd be better if it were toned down a bit

@bearrrrrrrr
Copy link

bearrrrrrrr commented Oct 11, 2024

actually minor request, can we keep the filter in but just not apply it to folk on spawn? i kinda wanna fuck around w/ it to maybe apply for dark areas or certain antags or smth

@kaylexis
Copy link

tbh i like the filter, but i do agree it'd be better if it were toned down a bit

There is some code relating to a CRT filter I removed in my original PR on subterra I suggest you use, if you want to keep the filter. PR it in as an automatically disabled option since some people are deranged and wish to live with a depression filter

@Ollanius
Copy link

I prefer the grit.

Keeping the Grimshart™ vision as a toggleable option (in the same tab-and-vein that the 'CRT' filter occupies) would be very nice. Like what Bear and Kaylexis said, it shouldn't be too hard to make it disabled by default for those who prefer a more clean-and-unassailed view.

@ChungusGamer666
Copy link

lmfao

@Hemlock32
Copy link

Don't see the need for this. It fits a particular artstyle/aesthetic quite well, sets a certain tone/mood, doesn't detract from anything.
It doesn't even remotely come off as "Poopdark" as people would say. It comes off as like, slightly gritty and dark at most.

And, when combined with the CRT filter it feels, incredibly flavourful like some old fantasy RPG game.

@chemistrymain3
Copy link

Don't see the need for this. It fits a particular artstyle/aesthetic quite well, sets a certain tone/mood, doesn't detract from anything. It doesn't even remotely come off as "Poopdark" as people would say. It comes off as like, slightly gritty and dark at most.

And, when combined with the CRT filter it feels, incredibly flavourful like some old fantasy RPG game.

The reason is that it looks ugly and isn't done well and detracts from everything. Glad to clear this up.

@bearrrrrrrr
Copy link

my opinion on this kinda reversed. the game looks like hot dogshit without the filter because the people that made this code were talentless hacks that couldn't make something look good to save their lives.

i'd like if this was a toggle a la crt i think. thanks i love u

@kaylexis
Copy link

Don't see the need for this. It fits a particular artstyle/aesthetic quite well, sets a certain tone/mood, doesn't detract from anything. It doesn't even remotely come off as "Poopdark" as people would say. It comes off as like, slightly gritty and dark at most.

the definition poopdark used by spriters is for an unnecessarily gritty and dark atmosphere placed on sprites and/or a hud filter
i understand the aesthetic part but i think most people would rather have quality visuals over muh theme

@lpeapnni
Copy link

lpeapnni commented Nov 7, 2024

Just merge this shit bruh

@Lutowski
Copy link
Collaborator

Closing this because I'm about to PR in a toggle that should work.

@Lutowski Lutowski closed this Nov 16, 2024
DiscordWizard pushed a commit to DiscordWizard/Azure-PeakPants that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.