Feat/qf round close cap #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminlatifi
commented
Oct 8, 2024
•
aminlatifi
commented
- Renamed cumulativeCapPerProject to cumulativeUSDCapPerProject
- Renamed cumulativeCapPerUserPerProject to cumulativeUSDCapPerUserPerProject
- After this, the QfRound cap must be saved as the final cap in DB (etc. 1M$ and 1,050,000$) and not as a gap to sum of all EA rounds
renamed cumulativeCapPerUserPerProject to cumulativeUSDCapPerUserPerProject
ae2079
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
thanks @aminlatifi
just a question about the qf cap, if it is OK, feel free to merge
| (this.roundUSDCapPerProject || 0); | ||
|
|
||
| this.cumulativeCapPerUserPerProject = | ||
| this.cumulativeUSDCapPerProject = this.roundUSDCapPerProject || 0; |
There was a problem hiding this comment.
Don't we need to consider EA round caps?
There was a problem hiding this comment.
Qf round is independent of EA rounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.