-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/make slit illum interactive #330
base: master
Are you sure you want to change the base?
Conversation
…itive. Used the code from normalizeFlat as an example to make bin fitting interactive.
…m vizualizer (bineditor.py) by subclassing PrimitiveVizualizer.
…nd extended boundary
… below buttons for makeSlitIllum tabs to have room underneath
…ary_ext parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks!
I've pushed a number of commits to I would also favour removing the logging statements as I don't think they really add anything. The level of detail in the logs varies a lot from primitive to primitive but generally I would suggest a logging statement for the user whenever something slow is about to happen, or when a non-standard path is taken. Logging should also be used (perhaps at the |
list of changes: