-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding DRAGONS version to header of outputs #299
base: master
Are you sure you want to change the base?
Conversation
This will be added only at the end of the recipe. What about when I do writeOutputs() ? What about intermediate products that some primitives create? I don't actually have a solution. We don't want to add this to astrodata since we plan to split it out. Having recipe_system control it makes sense but I don't know when to add it. Let's think ahead... The versions that matter are the version of recipe_system (a bit) but mostly the version of geminidr. Think of the use where a third-party package, say maroonxdr, is used. We need that version number too. It will use geminidr and maroonxdr, and "dragons". geminidr can be DRGNSVER, I don't see splitting geminidr out of DRAGONS anytime soon. Yet, I'd like to have a mechanism that would allow the external packages to add their version number too. |
Another worry I have is what happens with this PR implementation when I do |
|
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 57.88% 57.89%
=======================================
Files 249 249
Lines 28094 28097 +3
=======================================
+ Hits 16263 16266 +3
Misses 11831 11831
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In _write_final, if we are saving an output file, add a header keyword recording the version of DRAGONS used