Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reduce recording #297

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

olyoberdorf
Copy link
Contributor

record/replay capability for interactive use of fit1d/wavecal visualizers

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #297 (a83a8e2) into master (f8f8930) will increase coverage by 1.81%.
The diff coverage is 18.47%.

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   56.06%   57.87%   +1.81%     
==========================================
  Files         249      250       +1     
  Lines       28326    28666     +340     
==========================================
+ Hits        15881    16591     +710     
+ Misses      12445    12075     -370     
Flag Coverage Δ
gmosls 38.90% <18.47%> (-0.24%) ⬇️
integration 34.13% <18.20%> (-0.18%) ⬇️
regression 29.81% <15.21%> (-0.17%) ⬇️
slow 45.70% <18.47%> (?)
unit 47.59% <18.47%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geminidr/interactive/fit/aperture.py 17.32% <5.55%> (-0.72%) ⬇️
geminidr/interactive/fit/fit1d.py 12.42% <7.21%> (-0.67%) ⬇️
astrodata/fits.py 81.52% <12.69%> (-9.17%) ⬇️
geminidr/interactive/interactive.py 15.81% <13.63%> (+0.18%) ⬆️
geminidr/interactive/fit/wavecal.py 16.60% <20.00%> (+0.27%) ⬆️
geminidr/interactive/server.py 31.35% <20.00%> (-0.51%) ⬇️
recipe_system/utils/reduce_recorder.py 34.28% <34.28%> (ø)
astrodata/core.py 95.83% <42.85%> (-0.50%) ⬇️
recipe_system/reduction/coreReduce.py 66.09% <45.83%> (-2.48%) ⬇️
recipe_system/utils/reduce_utils.py 50.34% <100.00%> (+0.70%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f8930...a83a8e2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants