Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template lint errors in test files #97

Open
roomman opened this issue Oct 4, 2021 · 3 comments
Open

Template lint errors in test files #97

roomman opened this issue Oct 4, 2021 · 3 comments

Comments

@roomman
Copy link

roomman commented Oct 4, 2021

I'm adding some <Menu> tests and I am seeing ember-template-lint(prettier) errors in VSCode, wherever a template is rendered into a test file:

Screenshot 2021-10-04 at 10 18 52

Assuming others are not seeing these errors(?), and it's an issue with my editor's setup rather than the lint config, what extension are others using for formatting code in VSCode? Hopefully if I mirror, the problem will go away 🤞🏻

@GavinJoyce
Copy link
Owner

I'm seeing this too in my setup. It seems that it wants us to format is as follows:

Screenshot 2021-10-04 at 11 53 47

@GavinJoyce
Copy link
Owner

^ It's not terrible, but not necessarily better than what we have. I can see how this will become annoying.

I don't have a strong opinion, but I wouldn't be against disabling prettier for hbs in tests if we can't improve the experience

@alexlafroscia
Copy link
Collaborator

That's interesting... it specifically wants the code block aligned do that the first HBS line is all the way at the first column of the file?

I don't see this in my linting set up, which runs Prettier directly on HBS files, so I'm curious what tool specifically is causing this warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants