Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: carousel v2 #417

Merged
merged 7 commits into from
Oct 27, 2024
Merged

feature: carousel v2 #417

merged 7 commits into from
Oct 27, 2024

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • 調整輪播圖
  • 調整首頁輪播圖使用者操作

Changes made:

  • Carousel Component
  • AutoReset hook
  • ResizeObserver hook
  • home page

Test Scope / Change impact:

  • none (未來針對 hook 補單元測試)

Issue

@JohnsonMao JohnsonMao self-assigned this Oct 26, 2024
@github-actions github-actions bot added the feature New Feature label Oct 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GaaSBot
Copy link

GaaSBot commented Oct 26, 2024

✅ Knip Scan Result for f9bea0f

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/lobby/FastJoinButton.tsx
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/iconConverter/IconTemplate.tsx
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exported types (4)
Unused exported types (4)
CarouselButtonType enum components/shared/Carousel/v2/CarouselButton.tsx
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (1)
Unused exported types in namespaces (1)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
Unused exported enum members (1)
Unused exported enum members (1)
PRIMARY_TRANSPARENT ButtonVariant components/shared/Button/v2/Button.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Oct 26, 2024

🤖 Lighthouse Scan Result for f9bea0f

/rooms
Metric Value
Performance 70
Seo 78
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 65
Seo 78
Accessibility 80
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 74
Seo 78
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit 38519ae into main Oct 27, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the feature/carousel-v2 branch October 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnsonMao JohnsonMao

Labels
feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Carousel Component - 13 Point
2 participants
@JohnsonMao @GaaSBot