Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Description on fee reimbursement transactions #95

Open
vindard opened this issue May 9, 2022 · 1 comment
Open

Description on fee reimbursement transactions #95

vindard opened this issue May 9, 2022 · 1 comment

Comments

@vindard
Copy link
Contributor

vindard commented May 9, 2022

Background

On ln payments without fee probes, we usually debit a "max fee" from the user, execute the payment, and then credit back the fee difference with the actual fee via a fee reimbursement transaction. This appears as 2 separate transactions in a user's transactions history.

Issue

The reimbursement transaction currently shows up as a credit from our Galoy wallet with no other context, which could be confusing for a user.

Should we flag these reimbursement transactions any differently somehow?

image

@pretyflaco
Copy link

Throwing out wording ideas, maybe sth like:

Description:
Fee Reimbursement: Found cheaper route for payment {id}

Description:
Fee Reimbursement: Found cheaper route previous LN payment

Description:
Fee Back! Found cheaper route for previous LN payment

Description:
Fee Back! Found cheaper route for payment {id}

galoybot pushed a commit that referenced this issue Jul 17, 2022
* fix: annualize funding yield
* chore: add supplemental annualized funding yield
* chore: use annualized funding yield in exporter
Co-authored-by: Sebastien Verreault <[email protected]>
galoybot pushed a commit that referenced this issue Mar 22, 2023
…3.0 (#95)

Bumps [@graphql-codegen/client-preset](https://github.com/dotansimha/graphql-code-generator/tree/HEAD/packages/presets/client) from 1.2.3 to 1.3.0.
- [Release notes](https://github.com/dotansimha/graphql-code-generator/releases)
- [Changelog](https://github.com/dotansimha/graphql-code-generator/blob/master/packages/presets/client/CHANGELOG.md)
- [Commits](https://github.com/dotansimha/graphql-code-generator/commits/@graphql-codegen/[email protected]/packages/presets/client)

---
updated-dependencies:
- dependency-name: "@graphql-codegen/client-preset"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants