Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility shims from GHC.Num.Compat (and move them to a better-named module) #1702

Open
RyanGlScott opened this issue Jul 10, 2024 · 0 comments
Labels
tech-debt For issues that require some internal refactoring.

Comments

@RyanGlScott
Copy link
Contributor

Currently, the GHC.Num.Compat module use quite a lot of CPP to define functions that are intended to work with both pre-9.0 and post-9.0 versions of GHC (9.0 is when the ghc-bignum library was introduced). Nowadays, the minimum tested version of GHC that we use in Cryptol is GHC 9.2, which means that we are no longer building any of the pre-9.0 code paths in GHC.Num.Compat. As such, it's possible that this code has bitrotten.

We should remove all of the pre-9.0 code from this module. After we do this, the name ".Compat" won't be appropriate any more, as there won't be anything compatibility-related in the module. We should figure out a better name for the module at that point (perhaps Cryptol.Utils.Num or something similar).

@RyanGlScott RyanGlScott added the tech-debt For issues that require some internal refactoring. label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt For issues that require some internal refactoring.
Projects
None yet
Development

No branches or pull requests

1 participant