Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to update the non-dist version of manifest.json #81

Open
1 task done
melink14 opened this issue May 11, 2021 · 1 comment
Open
1 task done

No way to update the non-dist version of manifest.json #81

melink14 opened this issue May 11, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@melink14
Copy link

Issue

  • I have searched the issues of this repository and believe that this is not a duplicate.

Your Environment

  • semantic-release-chrome version: 1.1.3

What you did and problem description

I've added semantic-release-chrome to a standard chrome extension package which has various source files that get compiled to a /dist folder via an npm build script.

My goal was to have semantic-release-chrome modify the manifest.json with the new version and then have that commited along with package.json and CHANGELOG.md as part of the final release commit.

What happened

Only the dist folder manifest.json is updated which means CWS will get the new version but not GitHub

Suggested solution

Maybe take an array of paths to update the manifest?
This is a bit tricky since updating and zipping both happen during the prepare step which means there's no chance for another plugin to do anything in beween.

Right now, my work around will be to copy the manifest from dest back to src folder in an exec plugin that comes later.

@GabeDuarteM GabeDuarteM added the enhancement New feature or request label Jul 5, 2022
@ngshiheng
Copy link

hey @GabeDuarteM, can I ask if you're accepting contributions for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants