Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Utilities FileNotFoundException - playerdata.dat.tmp not found #18344

Closed
3 tasks done
Matejko124 opened this issue Dec 11, 2024 · 0 comments · Fixed by GTNewHorizons/ServerUtilities#156
Closed
3 tasks done
Labels
Bug: Minor Mod: Server Utilities Status: Ready for Developer Issue ready for a developer to pick up and implement

Comments

@Matejko124
Copy link

Your GTNH Discord Username

Matejko124

Your Pack Version

2.7.0

Your Server

Private Server

Java Version

Java 21

Type of Server

None

Your Expectation

I run my server with Server Utilities on so that it backs up every 30 minutes. It ran without issues on the previous version, 2.6.2.

The Reality

The backup semi-frequently fails to save the world with the following error:

[21:43:47] [Thread-19/ERROR] [Server Utilities/]: Error while backing up
java.io.FileNotFoundException: ./world/playerdata/20752898-d26a-4baa-a493-c8552ce19b4a.dat.tmp (No such file or directory)
	at java.base/java.io.FileInputStream.open0(Native Method) ~[?:?]
	at java.base/java.io.FileInputStream.open(FileInputStream.java:213) ~[?:?]
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:152) ~[?:?]
	at Launch//serverutils.lib.util.compression.CommonsCompressor.addFileToArchive(CommonsCompressor.java:34) ~[CommonsCompressor.class:?]
	at Launch//serverutils.task.backup.ThreadBackup.compressFile(ThreadBackup.java:139) ~[ThreadBackup.class:?]
	at Launch//serverutils.task.backup.ThreadBackup.compressFiles(ThreadBackup.java:132) ~[ThreadBackup.class:?]
	at Launch//serverutils.task.backup.ThreadBackup.doBackup(ThreadBackup.java:85) [ThreadBackup.class:?]
	at Launch//serverutils.task.backup.ThreadBackup.run(ThreadBackup.java:66) [ThreadBackup.class:?]

Note that a manual backup does not have this issue, nor does it happen with single-threaded backups enabled. It fails to find any UUID, not just the one listed. Appears to be some sort of race condition where it tries to read the .tmp file instead of .dat file for playerdata. World saves might not be closing correctly.

I am attaching a log file along with the SU config. (Ctrl + F ".tmp")
serverutilities.txt
fml-server-log.txt

Your Proposal

Check if vanilla server saves are paused when backups run. Prevent SU to read said .tmp files.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Matejko124 Matejko124 added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 11, 2024
@Lyfts Lyfts added Mod: Server Utilities Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: Server Utilities Status: Ready for Developer Issue ready for a developer to pick up and implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants