Weedex does not prevent weedgrowth from 24+ crops on empty double or single cropsticks

[qunYp3dZSyLjoEoEg]

Your GTNH Discord Username

No response

Your Pack Version

2.6.1

Your Server

Stonehuts

Java Version

Java 21

Type of Server

Thermos

Your Expectation

I tried to breed stickreed as a base crops to further breed other crops to 32/32/0 and then eventually 32/32/32. In order to have weedex applied to only the double cropstickso as to not damage the crops, I decided to put the breeding thingy right at the edge of my cropmatrons range with just the double cropstick within their range.

The Reality

Weeds still grow no matter whether it is a single cropstick or a double cropstick even if there has been a weedex application from the cropmatron.

Your Proposal

Make it so that no weeds grow in such a case.

Final Checklist

• I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[mitchej123]

Weedex doesn't damage crops. That myth was debunked.

[qunYp3dZSyLjoEoEg]

"However, Weed-EX can cause stat loss if used on a crop which is considered a weed. Specifically: " That is what I was reeferring to (from the wiki) with damage. if that is incorrect then sorry

[qunYp3dZSyLjoEoEg]

https://gtnh.miraheze.org/wiki/IC2_Crops#Weeds

[qunYp3dZSyLjoEoEg]

It also says there that a cropstick with weedex on it is supposed to be immune to all weedex spreading effects which is why I filed this report

[qunYp3dZSyLjoEoEg]

P.S., it also happens when I have all the crops in my cropmatrons ranges

[mitchej123]

"However, Weed-EX can cause stat loss if used on a crop which is considered a weed. Specifically: " That is what I was reeferring to (from the wiki) with damage. if that is incorrect then sorry

That is inaccurate and should be updated -- we verified it in the code.

[mitchej123]

It also says there that a cropstick with weedex on it is supposed to be immune to all weedex spreading effects which is why I filed this report

Sure, I have no comment on that, haven't dug into it.

[qunYp3dZSyLjoEoEg]

Ah ok thank you!

"However, Weed-EX can cause stat loss if used on a crop which is considered a weed. Specifically: " That is what I was reeferring to (from the wiki) with damage. if that is incorrect then sorry

That is inaccurate and should be updated -- we verified it in the code.

[qunYp3dZSyLjoEoEg]

It also says there that a cropstick with weedex on it is supposed to be immune to all weedex spreading effects which is why I filed this report

Sure, I have no comment on that, haven't dug into it.

Totally fair, just wanted to post it here so it is documented in the proper channel.

[C0bra5]

I'm going to clear up some misconceptions since I've been digging into IC2 crops for way too long, and i know too much about them:

• When weed-ex is applied, and the new amount is >= 75, it has a chance to lower the growth or gain stat if the crop is a weed or considers itself a weed due to its growth stat (for most crops, that's gr >= 24, for venomilia, it's gr >= 7).
  • If the weed-ex is applied manually, there is a 1/5 chance it will attempt to lower the stats and a 1/3 chance if it's applied by a machine.
  • If the RNG check is successful, you have a 2/5 chance of getting a stat drop to either growth or gain and a guaranteed drop of 1 to your resistance.
• Weed-ex will prevent the crop stick from sprouting weeds on its own and consume one weed-ex unit 1/10th of the time when weed growth is prevented.
• Weed-ex will prevent another crop that acts like a weed from sprouting a weed into the crop stick if it has a crop that failed the RNG resistance check and consumes five weed-ex units when it does so.
  • Weed-ex does nothing to stop an empty or upgraded crop stick from sprouting weeds that originated from another crop, and this is by design, as far as I can tell.

Ic2 isn't a mod that the team can edit directly since it's closed source. We plan on replacing them with a custom mod for 2.8 which will hopefully be a lot clearer about how crops work in general.

[qunYp3dZSyLjoEoEg]

Ohhh thank you, sad to hear that that seems to be intended but what can I do.

[qunYp3dZSyLjoEoEg]

I'm going to clear up some misconceptions since I've been digging into IC2 crops for way too long, and i know too much about them:

* When weed-ex is applied, and the new amount is >= 75, it has a chance to lower the growth or gain stat if the crop is a weed or considers itself a weed due to its growth stat (for most crops, that's gr >= 24, for venomilia, it's gr >= 7).
  
  * If the weed-ex is applied manually, there is a 1/5 chance it will attempt to lower the stats and a 1/3 chance if it's applied by a machine.
  * If the RNG check is successful, you have a 2/5 chance of getting a stat drop to either growth or gain and a guaranteed drop of 1 to your resistance.

* Weed-ex will prevent the crop stick from sprouting weeds on its own and consume one weed-ex unit 1/10th of the time when weed growth is prevented.

* Weed-ex will prevent another crop that acts like a weed from sprouting a weed into the crop stick if it has a crop that failed the RNG resistance check and consumes five weed-ex units when it does so.
  
  * Weed-ex does nothing to stop an empty or upgraded crop stick from sprouting weeds that originated from another crop, and this is by design, as far as I can tell.

Ic2 isn't a mod that the team can edit directly since it's closed source. We plan on replacing them with a custom mod for 2.8 which will hopefully be a lot clearer about how crops work in general.

Do you happen to know whether crop managers and cropmatrons (or each one in case they behave slightly different) apply weedex to cropsticks with crops that have 24+ growth if these crops are at growth stage 2+?

[C0bra5]

Do you happen to know whether crop managers and cropmatrons (or each one in case they behave slightly different) apply weedex to cropsticks with crops that have 24+ growth if these crops are at growth stage 2+?

The crop manager is actually a bit weird on how it does weed-ex, it bypasses the IC2 weed-ex apply logic and just substitutes it's own: https://github.com/GTNewHorizons/GT5-Unofficial/blob/acfbaaf78e44f1da078419cd3f034a75aa0ea520/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/basic/MTECropHarvestor.java#L363-L389

When weed-ex is applied and the new amount is >= 75, and the crop is considered a weed (growth too high or is weed), there is a 33% chance that it will attempt to lower the crop's stats.

When it attempts to lower the stats:

• There is a 100% chance that resilience will go down by 1.
• There is a 20% chance that growth will go down by 1.
• There is a 40% chance that gain will go down by 1.

The IC2 Crop matron respects the standard rules of weed-ex.

In both cases, the crop's state does not prevent the application of weed-ex; they just do it as long as the weed-ex amount is low enough.

[qunYp3dZSyLjoEoEg]

Thank you!