Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XL SC power generation is inconsistent between dense and non dense steam #18226

Closed
3 tasks done
C0bra5 opened this issue Dec 5, 2024 · 1 comment · Fixed by GTNewHorizons/GT5-Unofficial#3602
Closed
3 tasks done
Labels
Bug: Minor Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement

Comments

@C0bra5
Copy link
Contributor

C0bra5 commented Dec 5, 2024

Your GTNH Discord Username

c0bra5

Your Pack Version

2.7.0 RC2

Your Server

SP

Java Version

Java 17

Type of Server

None

Your Expectation

The power generated between the XLSC turbine should be the same for equivalent dense and non dense steam flows

The Reality

They differ by about 100x because of this:
https://github.com/GTNewHorizons/GT5-Unofficial/blob/cce3f6745266e77589eb06f7f75875179e2fa101/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/multi/production/turbines/MTELargeTurbineSCSteam.java#L135-L138
image

They also differ because the optimal flow may not be a multiple of 1000, causing the optimal dense flow to be off from the actual optimal flow.

Huge ichorium with optimal dense SC steam flow (614L//t)
image

Huge Ichorium with optimal SC steam flow (614400L/t)
image

Your Proposal

Since the Large SC Steam Generator doesn't discriminate, this behaviour should be standardized, or there should be some documentation indicating why the XLSC needs to discriminate.

The amount of power generated for optimal dense flow should be same as the regular optimal flow.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@C0bra5 C0bra5 added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 5, 2024
@chochem chochem added Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 5, 2024
@chochem chochem mentioned this issue Dec 5, 2024
@Mr233sir
Copy link

Mr233sir commented Dec 9, 2024

This problem still exists in final version of 2.7.0
QQ图片20241209170857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: GT GregTech and its (former) addons Status: Ready for Developer Issue ready for a developer to pick up and implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants