Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart fixes #329

Open
thanasis457 opened this issue Nov 8, 2024 · 0 comments · May be fixed by #333
Open

Chart fixes #329

thanasis457 opened this issue Nov 8, 2024 · 0 comments · May be fixed by #333
Assignees

Comments

@thanasis457
Copy link
Contributor

thanasis457 commented Nov 8, 2024

Description

The chart components all have minor issues that should be completely mitigated by the end of this sprint.

Donut

  • The user should not be allowed to insert negative values.
  • If an entry is empty, everything becomes NaN. Assume that empty entries are zero to handle this issue. (So when the state changes, set the value to 0, not empty.)

Progress Bar

  • The user should not be allowed to insert negative values for either the goal or current status.

Line

  • All the values are showing one value above what they are. Eg. 0 shows as 1 on the graph, 4 as 5, etc.
  • The x-axis should only support numbers. Right now it supports any value. Only allow numbers and make sure that the order is correct, i.e. if the user passes in x-values: 1, 0, -1, 5 that should be allowed but on the map they will show up sorted as -1,0,1,5 and with the distances matching their values (so 1 and 5 will have 4 times the distance that 0 and 1 will have).
  • Remove the title. It should not show inside the box. Look on the section below for how titles should look.

General Issues

  • The title that the user passes in should show on the top of the chart here: image
  • When a button link or label has not been passed, the button at the bottom should not show up.
  • The radio buttons that let you select the type of chart are working but the UI is broken (you need to click two times to make the choice show). Please fix this.

Let me know if anything does not make sense. We need these to be working properly before deployment.

@charliejlin charliejlin linked a pull request Nov 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants