Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull-Request Rules #1

Open
AlaaTaima opened this issue Jun 17, 2020 · 0 comments
Open

Pull-Request Rules #1

AlaaTaima opened this issue Jun 17, 2020 · 0 comments

Comments

@AlaaTaima
Copy link
Collaborator

AlaaTaima commented Jun 17, 2020

You should follow these rules with PR :

When you start working on any issue, follow these :

  1. Add it to the related project.
  2. Create a new branch as follow : issue Number-issue Title ex: 2-cardComponent.
  3. Open a pull request with In-progress label then start working.
  4. Make sure that your branch is up to date with master.
  5. Try to push every commit always to overcome any problem.
  6. Write a descriptive commit that show your changes.

When you want review for your pull-request :

  1. Change it's label to awaiting-review.
  2. Request review from team members and team lead.
  3. Make sure that you removed any console.log.
  4. Make sure that you removed unrelated files
  5. Make sure that it is working locally.
  6. Make sure that there are no ESlint issues in your code.
  7. Code is consistent with an agreed team style.
  8. Write a description that explains what is your component or page do.
  9. Write how to test your component to your reviewers.

AND KEEP IN YOUR MIND THAT THE PULL-REQUEST IS RELATED TO HIS ISSUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants