Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues Guide #6

Open
7 tasks done
Asmaathabet opened this issue Mar 26, 2020 · 8 comments
Open
7 tasks done

Issues Guide #6

Asmaathabet opened this issue Mar 26, 2020 · 8 comments
Assignees
Labels
Rules important things to follow during project phase

Comments

@Asmaathabet
Copy link
Member

Asmaathabet commented Mar 26, 2020

write your issue Clearly and neatly

  • Setup & configurations issues
  • Front End Routes & Back End Routes issues
  • Front End issues
  • Back End issues
  • Component Map
  • Component issues
  • Components Notes
@Asmaathabet Asmaathabet added the Rules important things to follow during project phase label Mar 26, 2020
@Asmaathabet
Copy link
Member Author

Setup & configurations issues ✔️

  • you should write the steps of setup something in details and neatly.
  • you should add any important configuration or instructions related to the issue.

@Asmaathabet
Copy link
Member Author

Asmaathabet commented Mar 26, 2020

Frontend [Applicants] Routes ✔️

Route Description Issue Number
/ Home page, displaying Hamburger Icons contain login sign up #1
/signin

@Asmaathabet
Copy link
Member Author

Backend [Admin] Routes ✔️

Route GET POST Delete Issue Number
/
/login login to the website by entering email and password #2

@Asmaathabet
Copy link
Member Author

Front End Issues ✔️

  • Route
    / : Home
    protected : true

  • UI
    [take screenshot and add it here] 😄

@Asmaathabet
Copy link
Member Author

Asmaathabet commented Mar 26, 2020

Back End Issues ✔️

Home Route

display home page

Route : /

Method : GET


Main Things :

  • Database
  • Response
  • Test

Database :

Use database query to fetch data that related to specified applications by using application id that provided in the endpoint.


Response :

Response may be success or error :

  • Error :
    {
    error: "bad request",
    "Status-Code": 400
    }
  • Success
    {
    data: [] , 
    "Status-Code": 200    
    }

Test :

  • Route :
    Test route by testing all the expected cases for correct retrieve for data from application table.

  • Query :
    Test select database query to make sure that everything is ok .

@Asmaathabet
Copy link
Member Author

Asmaathabet commented Apr 8, 2020

  • Labels --> React , React-component, common- component, Front , Front End, Front End Routes

Components Map ✔️

No. component Name common Applicant admin pages Names Issue Number Assign to
1- Button yes - Applicant-Home , admin- Dashboard # @hassanannajjar

@Asmaathabet
Copy link
Member Author

  • Labels --> React , React-component, common-component [if it was common] ,applicant [if it was for applicant only], admin [if it was for admin only ] , Front End, to do

Issues Form :

Common Component | Button ✔️

or

Applicant Component | Button ✔️

or

Admin Component | Button ✔️


inside issue ex: Common Component - Button:

Our App will has many Buttons in many pages so, we have to use common component called Button and used it more than once.

  • Common Component Folder Name
    Button

  • It will be used in Pages
    Home , Dashboard

  • Material UI Link
    Button

  • UI Image From Design
    <<< image >>> 📷

@Asmaathabet
Copy link
Member Author

Asmaathabet commented Apr 8, 2020

Note :

when you work in component Don't Forget :
1- use Prop Types in every component .
https://reactjs.org/docs/typechecking-with-proptypes.html
https://www.npmjs.com/package/prop-types

2- unified the style by one measurable unit which is rem = 16px.
3- creating the component as it needs to be [function , class ] .
4- component name's First Letter should be capital letter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rules important things to follow during project phase
Projects
None yet
Development

No branches or pull requests

5 participants