Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Notes #28

Open
Mu7ammadAbed opened this issue Aug 12, 2021 · 0 comments
Open

General Notes #28

Mu7ammadAbed opened this issue Aug 12, 2021 · 0 comments
Labels
enhancement New feature or request review

Comments

@Mu7ammadAbed
Copy link
Member

Mu7ammadAbed commented Aug 12, 2021

  1. WHERE IS THE README ?
  2. .env shouldn't be on Github.
  3. Why did you install axios and used it instead of `node-fetch?
  4. Why there are empty files?
  5. test.test.js should be called maybe index.test.js and should be in a separate folder on the root not in src.
  6. There's no need to handle the index.html for '/' route, it's handled by default with express.static.
  7. You can create a file and called it errors and export both clientError and serverError from it.
  8. Your list of requires needs edits in order 1. core 2. 3rd party modules 3. your own modules.
  9. You didn't use the router.
  10. You should edit your file structure and split app.js into index.js which contain the initial server listening and create a controller folder and a router.
  11. Why didn't you bring your API_KEY from the environment variables?
  12. Since you know how to destructure variables, why didn't you destructure the other one?
  const labelValue = req.params.label;
  const { option } = req.params;
  1. Your design needs a little fixation.
@Mu7ammadAbed Mu7ammadAbed added enhancement New feature or request review labels Aug 12, 2021
@aaamra aaamra mentioned this issue Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review
Projects
None yet
Development

No branches or pull requests

1 participant