Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text edit dialogue keeps the applied changes even after canceling the change. #3642

Open
sammy3110 opened this issue Oct 12, 2024 · 1 comment
Labels

Comments

@sammy3110
Copy link

Bug Description
While editing a text on the plane (Changing Font, Color etc.), the changes are reflected after clicking the apply button and are still retained if the CANCEL button is clicked.

GNS3 version and operating system

  • OS: Ubuntu 24.04.1 LTS
  • GNS3 version: 2.2.49
  • GNS3 VM with Vmware Workstation

Steps To Reproduce

  1. Select the 'Add a note' from the toolbar and write something on the plane.
  2. Right click on the note and select 'Text Edit'.
  3. Click on 'Select Font'.
  4. Make some changes (Font, Font Style, or Size).
  5. Click 'OK'.
  6. Click 'Apply' - THE CHANGES TAKE AFFECT.
  7. Click 'Cancel' - THE APPLIED CHANGES ARE STILL RETAINED.
@sammy3110 sammy3110 added the Bug label Oct 12, 2024
@grossmj
Copy link
Member

grossmj commented Oct 16, 2024

Thanks for opening an issue.

I believe this is the correct behavior. Once you click apply or click OK, the changes are applied on the item. The cancel button is just there to not apply any change and close the text editor dialog. Maybe we should add a reset button instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants