feat(attribute-completeness): support custom filter #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
force-pushed
the
ac-filter
branch
2 times, most recently
from
d417bdd to
52e6764
Compare
support custom attribute filter (given as ohsome filter query) for the attribute completeness indicator
matthiasschaub
force-pushed
the
ac-filter
branch
2 times, most recently
from
7c2f24a to
c2b1b28
Compare
matthiasschaub
force-pushed
the
ac-filter
branch
2 times, most recently
from
daf61b7 to
a37e06d
Compare
keep name closer to original pytest nodeid, but move approved files to
own directory "tests/approved/{module}".
move them to its own file
support custom attribute filter (given as ohsome filter query) for API endpoint /indicators/attribute-completeness
First transform model values from enums to dataclasses (e.g. TopicEnum -> TopicDefinition). Then use unpacking of arguments and keyword arguments to make function calls simpler.
check is not needed anymore because of request validation by pydantic models
matthiasschaub
force-pushed
the
ac-filter
branch
from
a37e06d to
75ec59d
Compare
to attribute title
Gigaszi
reviewed
Nov 26, 2024
| @@ -49,29 +54,54 @@ class BaseBpolys(BaseConfig): | |||
|
|
|||
| @field_validator("bpolys") | |||
| @classmethod | |||
| def transform(cls, value) -> geojson.FeatureCollection: | |||
| def transform_bpolys(cls, value): | |||
There was a problem hiding this comment.
why remove the return type here?
There was a problem hiding this comment.
No reason. I re-added the type hint!
| result = round(self.result.value * 100, 1) | ||
| if self.attribute_title is None: | ||
| raise TypeError("Attribute names should not be None.") | ||
| else: |
There was a problem hiding this comment.
why use names here and not title?
There was a problem hiding this comment.
Good catch. I started out with attribute names and changed it to title later on. Will correct it here.
Gigaszi
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support custom attribute definition via ohsome filter query for the Attribute Completeness indicator. Now, the API endpoint
attribute-completenesstakes eitherattributeKeysas before orattributeFilterandattributeNamesas parameters. The first is an ohsome filter query and the second is a list of attribute names represented by the ohsome filter query.Corresponding issue
Closes #840
New or changed dependencies
Checklist
main(e.g. throughgit rebase main)