Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shutdown of pFUnit tests in MAPL #3155

Open
tclune opened this issue Nov 5, 2024 · 0 comments
Open

Improve shutdown of pFUnit tests in MAPL #3155

tclune opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature

Comments

@tclune
Copy link
Collaborator

tclune commented Nov 5, 2024

pFUnit supports EXTRA_INITIALIZE and EXTRA_FINALIZE for global resources that will be used in the tests.

Currently MAPL/pfunit/MAPL_Initialize.F90 starts up a few global resources:

  • ESMF
  • pflogger
  • udunits

But there really should be a corresponding finalize that shuts these down (esp ESMF).

The task is to (1) create that routine and (2) modify the cmake macros that use MAPL_Initialize to also use the new finalize.

One option is to rename the host module for MAPL_initialize to be init/final and then put both routines in there. Easier to keep symmetric. Alternatively create a new module, but then the EXTRA_USE argument also needs to know the new module.

@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Development

No branches or pull requests

2 participants