refactor: address some code analysis issues

src/coreComponents/constitutive/ExponentialRelation.hpp

@@ -421,19 +421,19 @@ class ExponentialRelation
 private:
 
   /// variable shift
-  T m_x0;
+  T m_x0{};
 
   /// variable shift
-  T m_w0;
+  T m_w0{};
 
   /// scaling coefficient
-  T m_y0;
+  T m_y0{};
 
   /// exponential coefficient
-  T m_alpha;
+  T m_alpha{};
 
   /// exponential coefficient
-  T m_beta;
+  T m_beta{};
 
 };
 

src/coreComponents/constitutive/fluid/multifluid/CO2Brine/functions/PhillipsBrineViscosity.hpp

@@ -143,7 +143,7 @@ void PhillipsBrineViscosityUpdate::compute( real64 const & pressure,
   using Deriv = constitutive::multifluid::DerivativeOffset;
 
   // compute the viscosity of pure water as a function of temperature
-  real64 dPureWaterVisc_dTemperature;
+  real64 dPureWaterVisc_dTemperature = 0.0;
   real64 const pureWaterVisc = m_waterViscosityTable.compute( &temperature, &dPureWaterVisc_dTemperature );
 
   // then compute the brine viscosity, accounting for the presence of salt

src/coreComponents/constitutive/solid/ElasticIsotropicPressureDependent.hpp

@@ -337,7 +337,7 @@ void ElasticIsotropicPressureDependentUpdates::smallStrainUpdate( localIndex con
   real64 eps_v_elastic;
   real64 oldElasticStrainVol;
   real64 oldElasticStrainDev;
-  real64 bulkModulus = -p0/Cr;
+  real64 bulkModulus;
 
   for( localIndex i=0; i<6; ++i )
   {

src/coreComponents/dataRepository/xmlWrapper.cpp

@@ -429,7 +429,6 @@ size_t findAttribute( string const & attName, string const & xmlBuffer, size_t c
         {
           return candidatePos;
         }
-        searchStart = candidatePos + attName.size();
       }
     }
     catch( std::regex_error const & )

src/coreComponents/fileIO/timeHistory/HistoryCollectionBase.cpp

@@ -189,9 +189,6 @@ dataRepository::Group const * HistoryCollectionBase::getTargetObject( DomainPart
           }
           else
           {
-            string const targetTokensStr = stringutilities::join( targetTokens.begin(),
-                                                                  targetTokens.begin()+pathLevel,
-                                                                  '/' );
             GEOS_THROW( targetTokens[pathLevel] << " not found in path " <<
                         objectPath << std::endl << targetGroup->dumpSubGroupsNames(),
                         std::domain_error );

src/coreComponents/finiteElement/elementFormulations/ConformingVirtualElementOrder1.hpp

@@ -85,18 +85,18 @@ class ConformingVirtualElementOrder1 final : public FiniteElementBase
     {}
 
     /// The number of support points.
-    localIndex numSupportPoints;
+    localIndex numSupportPoints{};
     /// The quadrature weight.
-    real64 quadratureWeight;
+    real64 quadratureWeight{};
     /// Array holding the integral mean of basis functions in the first @ref numSupportPoints
     /// positions.
-    real64 basisFunctionsIntegralMean[MAXCELLNODES];
+    real64 basisFunctionsIntegralMean[MAXCELLNODES]{};
     /// The stabilization matrix. Valid values will be in the upper left @ref numSupportPoints x
     /// @ref numSupportPoints block.
-    real64 stabilizationMatrix[MAXCELLNODES][MAXCELLNODES];
+    real64 stabilizationMatrix[MAXCELLNODES][MAXCELLNODES]{};
     /// Array holding the integral mean of derivatives of basis functions in the first @ref
     /// numSupportPoints position of the first dimension.
-    real64 basisDerivativesIntegralMean[MAXCELLNODES][3];
+    real64 basisDerivativesIntegralMean[MAXCELLNODES][3]{};
   };
 
   /**

src/coreComponents/mesh/utilities/StructuredGridUtilities.hpp

@@ -16,6 +16,10 @@
 #ifndef GEOS_MESH_UTILITIES_STRUCTUREDGRIDUTILITIES_HPP
 #define GEOS_MESH_UTILITIES_STRUCTUREDGRIDUTILITIES_HPP
 
+#include "common/logger/Logger.hpp"
+#include "common/GeosxMacros.hpp"
+#include <vector>
+
 /**
  * @file StructuredGridUtilities.hpp
  */

src/coreComponents/physicsSolvers/contact/SolidMechanicsLagrangeContact.cpp

@@ -2344,7 +2344,7 @@ bool SolidMechanicsLagrangeContact::updateConfiguration( DomainPartition & domai
 
 bool SolidMechanicsLagrangeContact::isFractureAllInStickCondition( DomainPartition const & domain ) const
 {
-  globalIndex numStick, numNewSlip, numSlip, numOpen;
+  globalIndex numStick = 0, numNewSlip = 0, numSlip = 0, numOpen = 0;
   forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const &,
                                                                 MeshLevel const & mesh,
                                                                 arrayView1d< string const > const & )

src/coreComponents/physicsSolvers/contact/kernels/SolidMechanicsConformingContactKernelsBase.hpp

@@ -291,8 +291,8 @@ struct ComputeRotationMatricesKernel
     forAll< POLICY >( size, [=] GEOS_HOST_DEVICE ( localIndex const k )
     {
 
-      localIndex const & f0 = elemsToFaces[k][0];
-      localIndex const & f1 = elemsToFaces[k][1];
+      localIndex const f0 = elemsToFaces[k][0];
+      localIndex const f1 = elemsToFaces[k][1];
 
       real64 Nbar[3];
       Nbar[0] = faceNormal[f0][0] - faceNormal[f1][0];

src/coreComponents/physicsSolvers/fluidFlow/kernels/compositional/SolutionScalingAndCheckingKernelBase.hpp

@@ -84,6 +84,7 @@ class SolutionScalingAndCheckingKernelBase
 
     StackVariables( real64 _localMinVal )
       :
+      localRow( -1 ),
       localMinVal( _localMinVal )
     { }
 

src/coreComponents/physicsSolvers/fluidFlow/kernels/singlePhase/ResidualNormKernel.hpp

@@ -21,6 +21,8 @@
 #define GEOS_PHYSICSSOLVERS_FLUIDFLOW_SINGLEPHASE_RESIDUALNORMKERNEL_HPP
 
 #include "physicsSolvers/PhysicsSolverBaseKernels.hpp"
+#include "physicsSolvers/fluidFlow/FlowSolverBaseFields.hpp"
+#include "mesh/ElementSubRegionBase.hpp"
 
 namespace geos
 {

src/coreComponents/physicsSolvers/multiphysics/HydrofractureSolver.cpp

@@ -403,8 +403,8 @@ void HydrofractureSolver< POROMECHANICS_SOLVER >::setupCoupling( DomainPartition
         regions.emplace_back( region.getName() );
       } );
 
-      dispMeshTargets[std::make_pair( meshBodyName, solidDiscretizationName )] = std::move( regions );
-      presMeshTargets[std::make_pair( meshBodyName, flowDiscretizationName )] = std::move( regions );
+      dispMeshTargets[std::make_pair( meshBodyName, solidDiscretizationName )] = regions;
+      presMeshTargets[std::make_pair( meshBodyName, flowDiscretizationName )] = regions;
     } );
 
     dofManager.addCoupling( solidMechanics::totalDisplacement::key(),

src/coreComponents/physicsSolvers/wavePropagation/sem/acoustic/secondOrderEqn/isotropic/AcousticWaveEquationSEM.cpp

@@ -1210,7 +1210,7 @@ real64 AcousticWaveEquationSEM::explicitStepInternal( real64 const & time_n,
 
   GEOS_LOG_RANK_0_IF( dt < epsilonLoc, "Warning! Value for dt: " << dt << "s is smaller than local threshold: " << epsilonLoc );
 
-  real64 dtCompute;
+  real64 dtCompute = 0.0;
   forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const &,
                                                                 MeshLevel & mesh,
                                                                 arrayView1d< string const > const & regionNames )

src/coreComponents/physicsSolvers/wavePropagation/sem/elastic/secondOrderEqn/isotropic/ElasticWaveEquationSEM.cpp

@@ -958,7 +958,7 @@ real64 ElasticWaveEquationSEM::explicitStepInternal( real64 const & time_n,
 
   GEOS_LOG_RANK_0_IF( dt < epsilonLoc, "Warning! Value for dt: " << dt << "s is smaller than local threshold: " << epsilonLoc );
 
-  real64 dtCompute;
+  real64 dtCompute = 0.0;
   forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const &,
                                                                 MeshLevel & mesh,
                                                                 arrayView1d< string const > const & regionNames )