refactor: address some code analysis issues #3456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
commented
Nov 20, 2024
| @@ -337,7 +337,7 @@ void ElasticIsotropicPressureDependentUpdates::smallStrainUpdate( localIndex con | |||
| real64 eps_v_elastic; | |||
| real64 oldElasticStrainVol; | |||
| real64 oldElasticStrainDev; | |||
| real64 bulkModulus = -p0/Cr; | |||
There was a problem hiding this comment.
reassigned below, down in the code
paveltomin
commented
Nov 20, 2024
paveltomin
commented
Nov 20, 2024
src/coreComponents/fileIO/timeHistory/HistoryCollectionBase.cpp
Outdated
Show resolved
Hide resolved
paveltomin
requested review from
CusiniM,
ryar9534,
rrsettgast,
wrtobin,
untereiner,
MelReyCG,
corbett5,
castelletto1,
jhuang2601 and
dkachuma
as code owners
paveltomin
added
the
ci: run integrated tests
paveltomin
requested review from
sframba,
acitrain,
frankfeifan,
matteofrigo5,
Guotong-Ren and
andrea-borio
as code owners
paveltomin
added
type: cleanup / refactor
paveltomin
changed the title
paveltomin
commented
Nov 20, 2024
| @@ -429,7 +429,6 @@ size_t findAttribute( string const & attName, string const & xmlBuffer, size_t c | |||
| { | |||
| return candidatePos; | |||
| } | |||
| searchStart = candidatePos + attName.size(); | |||
Guotong-Ren
approved these changes
Nov 20, 2024
paveltomin
commented
Nov 21, 2024
| @@ -189,9 +189,6 @@ dataRepository::Group const * HistoryCollectionBase::getTargetObject( DomainPart | |||
| } | |||
| else | |||
| { | |||
| string const targetTokensStr = stringutilities::join( targetTokens.begin(), | |||
paveltomin
changed the title
paveltomin
removed
the
ci: run integrated tests
MelReyCG
approved these changes
Nov 26, 2024
| @@ -84,6 +84,7 @@ class SolutionScalingAndCheckingKernelBase | |||
|
|
|||
| StackVariables( real64 _localMinVal ) | |||
| : | |||
| localRow( -1 ), | |||
There was a problem hiding this comment.
Just a question: why -1 instead of 0? (=> localRow())
There was a problem hiding this comment.
-1 to force it to crash when something goes wrong
Comment on lines
+406
to
+407
| dispMeshTargets[std::make_pair( meshBodyName, solidDiscretizationName )] = regions; | ||
| presMeshTargets[std::make_pair( meshBodyName, flowDiscretizationName )] = regions; |
There was a problem hiding this comment.
How did the previous code worked?? Good catch!
There was a problem hiding this comment.
i don't think using moved is a big deal here but better not to use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.