Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 삭제여부 Converter이용, Clinic파트 Service, Controller - Dto 설정 -#12 #13

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: 삭제여부 Converter이용, Clinic파트 Service, Controller - Dto 설정 -#12 #13

wants to merge 10 commits into from

Conversation

wimmings
Copy link
Member

feat: 삭제여부 Converter이용, Clinic파트 Service, Controller - Dto 설정 -#12

변경 사항

  1. @converter 이용해서 만들고, 해당 엔티티-필드에 @convert(converter = BooleanToTFConverter.class) 추가

  2. Clinic부분의 Service, Controller 생성, Dto 사용

  3. 제네릭 생략


참고 사항

  1. FeelingPost는 감정 수정 불가(긍정/부정만 있어서 처음 선택에서 많이 안 벗어날 것 같았습니다), 글은 수정가능
  2. ClinicPost는 제목, 글 수정가능
    으로 구현했습니다.

closed #12

@wimmings wimmings requested a review from grand7070 March 13, 2023 09:06
@wimmings wimmings self-assigned this Mar 13, 2023
grand7070
grand7070 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@grand7070 grand7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 이것저것 말씀드릴 껀 많은데 계속 진도가 안나가므로 일단 approve 하겠습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grand7070 grand7070 grand7070 approved these changes

Assignees

@wimmings wimmings

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] boolean DB저장시 Converter 이용, Clinic파트 Service, Controller 구현
2 participants
@wimmings @grand7070