-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download and organise DLRM data automatically #93
Download and organise DLRM data automatically #93
Conversation
os.system(f"unzip {os.path.join(dlrm_data_path, 'criteo', 'day23', 'fp32', 'day_23_sparse_multi_hot.npz')} -d {os.path.join(dlrm_data_path, 'criteo', 'day23', 'fp32', 'day_23_sparse_multi_hot_unpacked')}") | ||
if os.path.exists(os.path.join(dlrm_data_path, "criteo", "day23", "fp32", "day_23_sparse_multi_hot.npz")): | ||
file_path = os.path.join(dlrm_data_path, "criteo", "day23", "fp32", "day_23_sparse_multi_hot.npz") | ||
run_cmd = ("echo {} {} | md5sum -c").format('c46b7e31ec6f2f8768fa60bdfc0f6e40', file_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to do md5sum check even for download right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... I tried to handle it in commit 19862dd
prehook_deps: | ||
- tags: get,ml-model,dlrm,_pytorch | ||
update_tags_from_env_with_prefix: | ||
download_path: CM_DLRM_DATA_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_
missing? Also this uses a list right?
- "on" | ||
- tags: get,dataset,preprocessed,criteo,_mlc | ||
update_tags_from_env_with_prefix: | ||
output_dir: CM_DLRM_DATA_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is output_dir
a tag?
print(f'day_23_labels.npy is missing inside {dlrm_data_path}/criteo/day23/fp32') | ||
env['CM_DLRM_DATASET_DOWNLOAD'] = True | ||
# TBD: raw data is not available with mlcommons hosted dataset | ||
#if not os.path.exists(os.path.join(dlrm_data_path, "criteo", "day23", "raw_data")): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should now turn this check on and ask user to point to this file via an input say criteo_day23_raw_data_path
. This is the link to download the rawdata but only manual download is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would criteo_raw_data_path
and CM_CRITEO_RAW_DATA_PATH
be a good naming option for input mapping and env variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need day23 too as we only need to download day23 file - not the entire raw data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1dec20a incorporated in this commit
No description provided.