Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and organise DLRM data automatically #93

Merged

Conversation

anandhu-eng
Copy link

No description provided.

@anandhu-eng anandhu-eng marked this pull request as draft July 19, 2024 16:41
os.system(f"unzip {os.path.join(dlrm_data_path, 'criteo', 'day23', 'fp32', 'day_23_sparse_multi_hot.npz')} -d {os.path.join(dlrm_data_path, 'criteo', 'day23', 'fp32', 'day_23_sparse_multi_hot_unpacked')}")
if os.path.exists(os.path.join(dlrm_data_path, "criteo", "day23", "fp32", "day_23_sparse_multi_hot.npz")):
file_path = os.path.join(dlrm_data_path, "criteo", "day23", "fp32", "day_23_sparse_multi_hot.npz")
run_cmd = ("echo {} {} | md5sum -c").format('c46b7e31ec6f2f8768fa60bdfc0f6e40', file_path)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to do md5sum check even for download right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... I tried to handle it in commit 19862dd

prehook_deps:
- tags: get,ml-model,dlrm,_pytorch
update_tags_from_env_with_prefix:
download_path: CM_DLRM_DATA_PATH

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ missing? Also this uses a list right?

- "on"
- tags: get,dataset,preprocessed,criteo,_mlc
update_tags_from_env_with_prefix:
output_dir: CM_DLRM_DATA_PATH

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is output_dir a tag?

@anandhu-eng anandhu-eng marked this pull request as ready for review August 7, 2024 20:59
print(f'day_23_labels.npy is missing inside {dlrm_data_path}/criteo/day23/fp32')
env['CM_DLRM_DATASET_DOWNLOAD'] = True
# TBD: raw data is not available with mlcommons hosted dataset
#if not os.path.exists(os.path.join(dlrm_data_path, "criteo", "day23", "raw_data")):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should now turn this check on and ask user to point to this file via an input say criteo_day23_raw_data_path. This is the link to download the rawdata but only manual download is possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would criteo_raw_data_path and CM_CRITEO_RAW_DATA_PATH be a good naming option for input mapping and env variable?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need day23 too as we only need to download day23 file - not the entire raw data.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1dec20a incorporated in this commit

@arjunsuresh arjunsuresh merged commit 410a33c into GATEOverflow:mlperf-inference Aug 7, 2024
39 checks passed
anandhu-eng pushed a commit to anandhu-eng/cm4mlops that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants