DLRM model checksum + corrected pre download clean #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunsuresh
reviewed
Sep 24, 2024
script/download-file/run.sh
Outdated
| echo ${CM_PRE_DOWNLOAD_CLEAN_CMD} | ||
| ${CM_PRE_DOWNLOAD_CLEAN_CMD} | ||
| fi | ||
| echo ${CM_PRE_DOWNLOAD_CLEAN_CMD} |
arjunsuresh
reviewed
Sep 24, 2024
script/download-file/run.sh
Outdated
| @@ -26,6 +26,9 @@ elif [ -e "${CM_DOWNLOAD_DOWNLOADED_PATH}" ]; then | |||
| # checksum not supposed to fail for locally given file | |||
| if [[ "${CM_DOWNLOAD_LOCAL_FILE_PATH}" != "" ]]; then | |||
| exit 1 | |||
| else | |||
| echo "Checksum mismatch. Deleting through command: ${CM_PRE_DOWNLOAD_CLEAN_CMD}" | |||
There was a problem hiding this comment.
CM_PRE_DOWNLOAD_CLEAN=1
Is a cleaner code right?
There was a problem hiding this comment.
Hi @arjunsuresh , its assigned as true in commit b40ea46 to make it uniform since in customize.py, it expects true or false.
arjunsuresh
reviewed
Sep 24, 2024
script/download-file/run.sh
Outdated
| @@ -35,7 +37,7 @@ fi | |||
|
|
|||
| if [[ ${require_download} == "1" ]]; then | |||
| echo "" | |||
| if [ -e "${CM_PRE_DOWNLOAD_CLEAN}" ]; then | |||
| if [ "${CM_PRE_DOWNLOAD_CLEAN}" != "" ]; then | |||
There was a problem hiding this comment.
We should check for not equal to "False" here
arjunsuresh
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes progress to issue mlcommons#167.
Other modifications:
CM_PRE_DOWNLOAD_CLEANenv variable by default and we need to delete already existing incomplete download file.true. The incomplete downloads will not be cleared when user explicitly setsCM_PRE_DOWNLOAD_CLEANtofalse