added backup urls + added checksum verification for cmutil download #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandhu-eng
commented
Sep 13, 2024
| @@ -57,7 +57,7 @@ | |||
| "env": { | |||
| "CM_PACKAGE_URL": "https://www.dropbox.com/s/92n2fyej3lzy3s3/caffe_ilsvrc12.tar.gz", | |||
| "CM_PACKAGE_URL1": "http://dl.caffe.berkeleyvision.org/caffe_ilsvrc12.tar.gz", | |||
| "CM_DOWNLOAD_CHECKSUM_": "ee346d67141e476df9c1a3f813552503" | |||
| "CM_DOWNLOAD_CHECKSUM": "ee346d67141e476df9c1a3f813552503" | |||
| } | |||
There was a problem hiding this comment.
Could the same file hosted in separate platform have different checksum?
There was a problem hiding this comment.
Yes. Probably it's not the same zip.
There was a problem hiding this comment.
The _ was intentionally added to prevent the checksum being used as it can break the backup download.
arjunsuresh
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined pull request against issues:
mlcommons#197
mlcommons#196