feat(database/influxdb) add information if a node is a gateway to influxdb #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurerle
changed the title
|
This PR closes #227 I can confirm it works. |
genofire
requested changes
Sep 20, 2023
database/influxdb/node.go
Outdated
| @@ -53,6 +53,7 @@ func (conn *Connection) InsertNode(node *runtime.Node) { | |||
| "memory.total": stats.Memory.Total, | |||
| "memory.available": stats.Memory.Available, | |||
| } | |||
| tags.SetString("is_gateway", strconv.FormatBool(node.IsGateway())) | |||
There was a problem hiding this comment.
would you place it next to nodeid? for easier reading
otherwise it is fine
There was a problem hiding this comment.
Thanks!
I also removed the second tags.SetString("nodeid", stats.NodeID) which is redundant as we already added this to the tags and they are not cleared inbetween..?
maurerle
force-pushed
the
influx_is_gateway
branch
from
7a015bf
to
d403a45
Compare
genofire
reviewed
Sep 21, 2023
maurerle
force-pushed
the
influx_is_gateway
branch
2 times, most recently
from
200243a
to
37d4ef8
Compare
Signed-off-by: Florian Maurer <[email protected]>
maurerle
force-pushed
the
influx_is_gateway
branch
from
37d4ef8
to
b62a569
Compare
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think that the information if a node is a gateway should also be available in the influxdb:
is_gateway is more meaningful than "vpn" - which is the variable where this comes from actually.
I think, that this is more useful as a tag to filter than as a field of the data.
I did not find a way to add a boolean tag in influxdb, so I am writing it as string. (ref: https://stackoverflow.com/a/56989192 )
Motivation and Context
Checklist: