Move ruff.toml, pytest.ini and setup.cfg to pyproject.toml #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
commented
Oct 25, 2024
| __init__.py: F401, F403 | ||
| examples/*: F841, E402 | ||
| [pycodestyle] | ||
| max-line-length = 160 |
There was a problem hiding this comment.
removed the flake8 and pycodestyle config as it's replaced by ruff check.
|
|
||
| [tool.ruff] | ||
| line-length = 120 |
There was a problem hiding this comment.
Note that this line was previously ignored since ruff.toml file existed.
If a line length of 120 is set currently (or even 160) there is a bunch of errors. So probably if this is to be fixed, might be easier to start using ruff format...
There was a problem hiding this comment.
very strnage I did a reformating of many things in a recent commit.
but ok I can change that later
rth
force-pushed
the
move-config-to-pyproject.toml
branch
from
700a312
to
2705204
Compare
oroulet
reviewed
Oct 25, 2024
| "event_objects.py", | ||
| "standard_address_space_services.py" | ||
| ] | ||
| target-version = "py37" |
There was a problem hiding this comment.
should be 3.9 now, evertyhing else is not supported by Python
|
merge anyway, we can fix the other things later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1726 cc @oroulet