Bartelome enables Converts to be FreeColonists #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HighwayofLife
commented
May 24, 2023
•
HighwayofLife
commented
- Currently in FreeCol (and Col1), Bartelome joining congress causes native converts to be converted to Free Colonists. The effect is one-time.
- This change allows Native Converts to become Free Colonists by being "cleared" from the "clear specialty" menu option.
- This change also allows Native Converts to be educated in the outdoor skills that they are skilled at in half the time it would take a Free Colonist to be educated with that skill.
- Adds the ability for Free Colonists to gain experience when producing goods indoors and become experts.
- Percentage (probability) is based upon the skill level of the position.
- Carpenter is skill level 1, so has up to a 4% chance
- Statesmen and Preacher are skill level 3, so have up to a 2% chance
- All other occupations are skill level 2 and thus carry up to a 3% chance
- The current default behavior of FreeCol is that outdoor activities all carry up to a 4% chance, regardless of skill level.
Currently in FreeCol (and Col1), Bartelome joining congress causes native converts to be converted to Free Colonists. The effect is one-time. This change allows Native Converts to become Free Colonists by being "cleared" from the "clear specialty" menu option. This change also allows Native Converts to be educated in the outdoor skills that they are skilled at in half the time it would take a Free Colonist to be educated with that skill.
* Adds the ability for Free Colonists to gain experience when producing goods indoors and become experts. * Percentage (probability) is based upon the skill level of the position. * Carpenter is skill level 1, so has up to a 4% chance * Statesmen and Preacher are skill level 3, so have up to a 2% chance * All other occupations are skill level 2 and thus carry up to a 3% chance * The current default behavior of FreeCol is that outdoor activities all carry up to a 4% chance, regardless of skill level.
This was referenced May 24, 2023
stiangre
reviewed
May 25, 2023
| @@ -1797,7 +1797,7 @@ model.foundingFather.juanDeSepulveda.text=A Spanish theologian who spoke out for | |||
| model.foundingFather.juanDeSepulveda.birthAndDeath=1781-1872 | |||
|
|
|||
| model.foundingFather.bartolomeDeLasCasas.name=Bartolome de las Casas | |||
| model.foundingFather.bartolomeDeLasCasas.description=All existing Indian converts are converted to free colonists. | |||
| model.foundingFather.bartolomeDeLasCasas.description=All existing Indian converts can be converted to free colonists or educated in some outdoor work. | |||
There was a problem hiding this comment.
This changes the text also when playing with the classic ruleset ... and that would be wrong. The new text should be placed in a new file called "ModMessages.properties" in the "data/rules/freecol" directory.
I have noticed that we do not have support for including mod translatable messages to the "FreeColMessages.properties". This will be necessary in order to utilize translatewiki for getting the strings translated. We can, for example, automatically add/update the strings using the prefix "mod.MODID." as a part of our build process.
There was a problem hiding this comment.
I will send an email about supporting translations of rules/mods/maps/scenarios on the developer's mailing list.
stiangre
reviewed
May 25, 2023
| @@ -2203,7 +2203,7 @@ model.unit.hardyPioneer.description=The Hardy Pioneer excels at clearing forests | |||
| model.unit.indenturedServant.name={{plural:%number%|one=Indentured Servant|other=Indentured Servants|default=Indentured Servant}} | |||
| model.unit.indenturedServant.description=The Indentured Servant is well suited for outdoor work, but less suited for indoor work. He may become a Free Colonist through promotion or education. | |||
| model.unit.indianConvert.name={{plural:%number%|one=Indian Convert|other=Indian Converts|default=Indian Convert}} | |||
| model.unit.indianConvert.description=The Indian Convert is a native who has joined one of your colonies. He is skilled at all kinds of outdoor work, but unskilled at indoor work. As soon as Bartolome de las Casas joins the Continental Congress, all Indian Converts become Free Colonists. | |||
| model.unit.indianConvert.description=The Indian Convert is a native who has joined one of your colonies. He is skilled at all kinds of outdoor work, but unskilled at indoor work. As soon as Bartolome de las Casas joins the Continental Congress, all Indian Converts can become Free Colonists or educated in certain outdoor work. | |||
There was a problem hiding this comment.
The same comment as above.
stiangre
reviewed
May 25, 2023
| @@ -1317,7 +1316,7 @@ model.unit.indenturedServant.name=Vrygekoopte Dienskneg | |||
| model.unit.indenturedServant.description=Die Vrygekoopte Dienskneg is by uitstek geskik vir buitewerk, maar minder geskik vir binnewerk. Hy mag dalk 'n Vrye Kolonis word deur middel van bevordering of onderwys. | |||
| # Fuzzy | |||
| model.unit.indianConvert.name=Bekeerde inboorling | |||
| model.unit.indianConvert.description=Die Inheemse beerling is 'n inboorling wat hom by een van u kolonies aangesluit het. Hy is vaardig om alle vorme van buitewerk te doen, maar is ongeskoold op binnewerk. So gou as Bartolomé de las Casas aansluit by die Kontinentale Kongres, word alle Inheemse Bekeerlinge Vrye Koloniste. | |||
There was a problem hiding this comment.
We should never remove translated strings just because they are outdated. The string is marked as "Outdated" on translatewiki when the original string gets modified. Please do take a look at the interface our translators are presented with:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.