Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy to solve accessibility issues #212

Open
drmenzelit opened this issue Nov 20, 2024 · 9 comments
Open

Easy to solve accessibility issues #212

drmenzelit opened this issue Nov 20, 2024 · 9 comments

Comments

@drmenzelit
Copy link
Contributor

Very nice page with a few easy to solve issues:

  • Add an aria-label or a visually hidden text or an alternative text to the image in the h1
  • Change the <div id="main"...> to <main> element
  • Change the link color a little bit to have enough contrast (e.g. #4791fd has a ratio of 4.95 and meet WCAG SC 1.4.3)
  • Add an alternative text to the arrow image
  • Add an alternative text to the DigitalOcean image/link
  • Mark the language flag images as decorative (empty alternative text alt="")
  • Add missing h1/h2 on the subpages

Sorry if I'm not following specified guidelines, but the link to "contributing guidelines" leads to a php file without content ...

@chennes
Copy link
Member

chennes commented Nov 20, 2024

Thanks for your feedback, it's much appreciated. And sorry for the bad "contributing guidelines" link, we'll get that fixed up too. @Reqrefusion you want to take a stab at these? Or @drmenzelit are you planning on submitting a PR?

@AdarshRawat1
Copy link
Contributor

@drmenzelit Thanks for the feedback!

but the link to "contributing guidelines" leads to a php file without content ..

Could you help me identify which specific button or link you're referring to?

  • The one shown here appears to be working:
    image

@drmenzelit
Copy link
Contributor Author

@AdarshRawat1 this one on github:
grafik
When creating my first issue here I got a hint here (like a small popup):
grafik

@drmenzelit
Copy link
Contributor Author

@chennes if I find time in the next days I can check how the website is created and prepare a PR if you like

@chennes
Copy link
Member

chennes commented Nov 20, 2024

@drmenzelit that would be great -- if you don't have the time just drop a note here and I'll find someone to work on it.

@Reqrefusion
Copy link
Member

Reqrefusion commented Nov 20, 2024

If you want to deal with it, I don't need to deal with it for now. You can tag me if needed.

@yorikvanhavre
Copy link
Member

@drmenzelit is this issue fully solved with the PR you submitted? I think there are a few things missing, right?

@drmenzelit
Copy link
Contributor Author

It is not fully solved

@yorikvanhavre
Copy link
Member

Okay! Leaving this open then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants