Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greyscale: true generates ["#000000.36cd673"] #57

Open
nazimamin opened this issue Oct 22, 2015 · 0 comments
Open

greyscale: true generates ["#000000.36cd673"] #57

nazimamin opened this issue Oct 22, 2015 · 0 comments

Comments

@nazimamin
Copy link

greyscale: true or grayscale: true, doesn't generate hex value of 6 instead : "#000000.36cd673" .
jmanuel1 added a commit to jmanuel1/PleaseJS that referenced this issue May 26, 2016
@jmanuel1
Ensure hex strings are valid in make_color tests
1180846 
To make tests more complete, and to catch issue Fooidge#57.
jmanuel1 added a commit to jmanuel1/PleaseJS that referenced this issue Jun 2, 2016
@jmanuel1
Fix HSV_to_RGB calculation for grays
30e4296 
The value was neither scaled to a 0-255 range or converted to an
integer, so this function would return a color very close to black.
RGB_to_HEX fails to account for the non-integers, which explains the
decimal point as reported in issue Fooidge#57.
@jmanuel1 jmanuel1 mentioned this issue Jun 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nazimamin