Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_zero Roots.jl support #871

Open
themrzmaster opened this issue Jan 4, 2021 · 5 comments
Open

find_zero Roots.jl support #871

themrzmaster opened this issue Jan 4, 2021 · 5 comments

Comments

@themrzmaster
Copy link

themrzmaster commented Jan 4, 2021

Hi,
I've had a problem while testing Bijectors.jl that seems to be related with the fact that Zygote does not support the find_zero function.
Full Thread

Is there any plans to support it? Tracker AD supports it.
If someone could give me a hint if it makes sense or how I could help adding this compatibility, let me know.

Thanks

@mcabbott
Copy link
Member

mcabbott commented Jan 4, 2021

Can you write a minimial example of how this function is used, and a gradient which works with Tracker but not Zygote? There appears to be no explicit code for this in Tracker.

@mcabbott
Copy link
Member

mcabbott commented Jan 4, 2021

To be clear, I was hoping for a one-liner! I've no idea what this function does, what is its simplest input? And if you put that in gradient, does that reproduce the problem? Or does it work fine in all simple cases and only fail in the giant one with 5 other packages?

@themrzmaster
Copy link
Author

yes, I will do it!

@DhairyaLGandhi
Copy link
Member

Sounds like you want an adjoint for some of the functions called by find_zeros

@devmotion
Copy link
Collaborator

BTW like the SciML ecosystem Bijectors will probably switch to NonlinearSolve: TuringLang/Bijectors.jl#155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants