Import to Tape #50
Merged
Import to Tape #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Sep 3, 2021
DrChainsaw
reviewed
Sep 4, 2021
DrChainsaw
reviewed
Sep 4, 2021
darsnack
reviewed
Sep 4, 2021
There was a problem hiding this comment.
Looking good. Some minor nitpicks, but the one comment I had on the core of this PR was the approach to handling "missing rules" with load_node!. I think it's possible to do this with a default dispatch that returns missing, and it would be a more "Julian" approach.
Co-authored-by: Kyle Daruwalla <[email protected]>
darsnack
approved these changes
Sep 4, 2021
|
@ayush-1506 Since the codebase has changed significantly, would it make sense to grant write access to FluxML committers on this repo who are tracking this work (@ToucheSir and myself)? |
|
@darsnack Yes, unfortunately I don't have the required rights to grant write access to others. Tagging @DhairyaLGandhi here. |
|
Will do so. |
|
@DhairyaLGandhi Bump |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #49