Fix parsing dates with trailing spaces (Resolves #11) #39
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthew-carroll Could you please review this PR? |
|
We discussed offline that we should probably just test the parser because it would be unwieldy to maintain entire XML files for a detail as specific as an extra space in a single line. |
|
@matthew-carroll Updated. |
matthew-carroll
added a commit
that referenced
this pull request
Jan 14, 2024
#39) (#45) Co-authored-by: maxdreherwalsworth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing dates with trailing spaces. Resolves #11
If a feed contains a date with trailing spaces, for example
2024-01-08T00:19:00Z, theupdatedproperty of theWebFeedentry ends up beingnull.This PR fixes the issue by trimming the date before parsing.
We probably want to re-organize the existing tests.