Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the component layout #92

Open
javier-godoy opened this issue Dec 29, 2021 · 1 comment
Open

Refactor the component layout #92

javier-godoy opened this issue Dec 29, 2021 · 1 comment

Comments

@javier-godoy
Copy link
Member

Over the years, we have been stacking assumptions on how the component should look, while adding new features and migrating from Vaadin 8. In consequence:

  • The component inherits from VerticalLayout
  • There are three nested horizontal/vertical layouts (not even divs, but actual Flow components)
  • It's not clear which part of the layout is public API (which reduces room for non-breaking refactoring)
  • There is no clear API for styling

This change should be addressed in a major release.

@mlopezFC
Copy link
Member

We discussed about this and the idea is to create a basic web component that will act as a layout to simplify the dom structure. It will not be published as an external web component at least initially but will be embedded in the same jar.
So it will function 100% server side to maintain the API.

@paodb paodb moved this to Under consideration in Flowing Code Addons May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under consideration
Development

No branches or pull requests

3 participants