From de2c106987f37f1dafef69ee7a2ecee6230a3f96 Mon Sep 17 00:00:00 2001 From: jaarasys-henria <151676049+jaarasys-henria@users.noreply.github.com> Date: Fri, 2 Feb 2024 23:14:45 +0200 Subject: [PATCH] [Maintenance] Pass HTTPS flag to dev container to enable HTTPS (#2316) --- docker-compose.yml | 2 ++ packages/desktop-client/README.md | 6 ++++++ upcoming-release-notes/2316.md | 6 ++++++ 3 files changed, 14 insertions(+) create mode 100644 upcoming-release-notes/2316.md diff --git a/docker-compose.yml b/docker-compose.yml index 782aae5f4c7..91c62a91619 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -8,6 +8,8 @@ services: actual-development: build: . image: actual-development + environment: + - HTTPS ports: - '3001:3001' volumes: diff --git a/packages/desktop-client/README.md b/packages/desktop-client/README.md index 03b615faef1..fb9b36ac548 100644 --- a/packages/desktop-client/README.md +++ b/packages/desktop-client/README.md @@ -37,6 +37,12 @@ First start a dev instance: ```sh HTTPS=true yarn start ``` + +or using the dev container: +``` +HTTPS=true docker compose up --build +``` + Note the network IP address and port the dev instance is listening on. Next, navigate to the root of your project folder, run the standartised docker container, and launch the visual regression tests from within it. diff --git a/upcoming-release-notes/2316.md b/upcoming-release-notes/2316.md new file mode 100644 index 00000000000..f4d0760e04c --- /dev/null +++ b/upcoming-release-notes/2316.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [jaarasys-henria] +--- + +Enable passing HTTPS env variable flag to dev container for easy HTTPS enabling.