Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funding notes should be in context #129

Open
ywwg opened this issue Feb 13, 2019 · 1 comment
Open

funding notes should be in context #129

ywwg opened this issue Feb 13, 2019 · 1 comment
Labels
cleanup High Priority Next Year Stuff we will fix for the next year's grant server

Comments

@ywwg
Copy link
Collaborator

ywwg commented Feb 13, 2019

It's hard to know how the email will read without seeing the other sentences

@ywwg ywwg added Medium Priority cleanup Next Year Stuff we will fix for the next year's grant server labels Feb 13, 2019
@ywwg
Copy link
Collaborator Author

ywwg commented Jul 24, 2019

The trick with this is that the context depends on whether we fund or not. So we need some sort of ajaxy thing every time the funding amount is changed to update the text.

Maybe it's simple enough to have the box, and then below the box we print out the full email? That seems fine. To do that, we need to update that generated text when either the funding amount or funding notes are changed. And that will all be in the Grant Funding panel.

OK I have a basic design that looks all right. The next step is to make some js to update the preview as people type. The funding amount should always trigger a change. I think it's also ok to update on every keystroke of the funding notes as well, even though that's inefficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup High Priority Next Year Stuff we will fix for the next year's grant server
Projects
None yet
Development

No branches or pull requests

1 participant