Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Save to Quote" feature does not work for initial forum messages #171

Open
nakoyasha opened this issue Jul 19, 2024 · 5 comments
Open
Labels
bug Something isn't working on hold Currently on hold

Comments

@nakoyasha
Copy link

Describe the bug

Saving initial forum messages (aka, the very first message in a forum post) will not work, the bot will claim that it saved the message successfully, but will silently fail upon trying to embed that message.

To Reproduce

  • Make a forum channel
  • Make a post in the forum channel, and use "Save as Quote" on it
  • Try to embed it in a different channel

Expected behavior

For the message to be embedded like any other message

Screenshots

Discord & device versions
Canary 311260, Windows 11

Additional context

@nakoyasha nakoyasha added the bug Something isn't working label Jul 19, 2024
@GamingGeek
Copy link
Member

I'm unable to reproduce this issue and can quote saved initial forum messages just fine. Could you try again but when sending the link, change it to debug.discord.com and share a screenshot of what the bot responds with?

@nakoyasha
Copy link
Author

The bot seems to not reply to the message at all, maybe the link is different enough that it doesn't match anymore?

The link/message I'm trying to embed is https://debug.discord.com/channels/820745488231301210/1263229750655057950/1263229750655057950 (it's from No Text to Speech's discord)

Also, is the bot supposed to embed the message like normal (for messages that I know embed correctly) even when the link's domain is set to debug.discord.com? I might just be a little dum and missing something

@nakoyasha
Copy link
Author

nakoyasha commented Jul 20, 2024

Some of my friends (who are also able to reproduce this exact same issue) told me that it'd be better if we moved to Discord DMs, would that be okay? (if it is, my user is @nakoyasha)

@GamingGeek
Copy link
Member

Ah, I've managed to identify the issue. It was never about it being the first message in a forum channel but rather the size of the video in that message.

The maximum size that Fire will reupload is 10mb for non-premium, 25mb for premium and that video is just over 10mb. I tried myself with a 30mb file and encountered the same issue.

It should fallback to the old embed style of quoting in the case of files that are too large for it to reupload so I'll need to look into why it is not doing that

@GamingGeek GamingGeek added the work in progress A feature/bug that is currently being worked on label Jul 20, 2024
@GamingGeek
Copy link
Member

That didn't take long at all. It took me testing with my local instance to remember that cross cluster quotes (i.e. quoting from a different cluster since they are different processes) don't currently support the old style and require a webhook

I don't currently know whether or not I'll be able to support the old style nor do I know when I'd be able to add support for it if I can so for now, this is going to be put on hold for me to look at another time since it has become a much larger project than I initially expected

@GamingGeek GamingGeek added on hold Currently on hold and removed work in progress A feature/bug that is currently being worked on labels Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on hold Currently on hold
Projects
None yet
Development

No branches or pull requests

2 participants