Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI action cannot load env from secret #3

Open
tommady opened this issue Feb 28, 2022 · 2 comments
Open

CI action cannot load env from secret #3

tommady opened this issue Feb 28, 2022 · 2 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tommady
Copy link
Contributor

tommady commented Feb 28, 2022

There already has a secret named ETOE_WPK in the Repository secrets like the picture below
image

but somehow the CI action e2e.yml cannot load it when running the end to end tests described here
https://github.com/FindoraNetwork/refunder/blob/main/.github/workflows/release.yml#L24

the result leads e2e tests encountering an error like the below pic
image

I already tried many ways from googling around,
but still cannot resolve this.

Help wanted, if you need any resources for testing, please comment.

@tommady tommady added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed github_actions Pull requests that update GitHub Actions code labels Feb 28, 2022
@tharun634
Copy link

does just e2e run without any error, locally?

@tommady
Copy link
Contributor Author

tommady commented Mar 1, 2022

does just e2e run without any error, locally?

hi, thanks for replying.

the short answer is yes, run without any error locally.
since the just e2e is running those commands you can try it with golang command directly.

e2e:
	# need to run the e2e tests one by one or will facing 
	# `send_raw_transaction: broadcast_tx_sync failed` error
	go test -v -tags=e2e -count=1 ./e2e/giveaway/...
	go test -v -tags=e2e -count=1 ./e2e/gasfee/...

and when running in the local all you need is to

export E2E_WPK=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

and that action error is only happened (IMHO) if you did not export the E2E_WPK env then run it.

I tried to add a condition like this
d0d2bcf
as you can see the

# the original name (ya I tried to make the env name shorter, does not work)
env.TESTING_WALLET_PRIVATE_KEY == ""

so the action passed...

this makes me so wondering, why I just could not set the env correctly in the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants