Merge pull request #93 from jamesnicholls/pin-puppeteer-version

Pin puppeteer version
Financial-Times · Nov 6, 2018 · c3b581f · c3b581f
2 parents 9afc530 + 669dd4d
commit c3b581f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/smoke/smoke-test.js b/lib/smoke/smoke-test.js
@@ -66,7 +66,9 @@ class SmokeTest {
 		const crossBrowserTests = [];
 
 		// https://github.com/GoogleChrome/puppeteer/issues/2377
-		const launchOptions = (process.env.NODE_ENV === 'development') ? {args: ['--ignore-certificate-errors', '--enable-features=NetworkService']} : {};
+		const launchOptions = (process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'test') ?
+			{args: ['--ignore-certificate-errors', '--enable-features=NetworkService', '--no-sandbox', '--disable-setuid-sandbox']} :
+			{};
 		this.browser = await puppeteer.launch(launchOptions);
 
 		for (let suiteOptions of configsToRun) {

diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
         "directly": "^2.0.6",
         "inquirer": "^5.0.1",
         "node-fetch": "^2.1.1",
-        "puppeteer": "^1.8.0",
+        "puppeteer": "1.9.0",
         "webdriverio": "^4.11.0"
     },
     "devDependencies": {