Skip to content

Commit

Permalink
Merge pull request #201 from Financial-Times/support-node-18
Browse files Browse the repository at this point in the history
CPP-1388: Add support for node.js 18
  • Loading branch information
jkerr321 authored Apr 26, 2023
2 parents d03e9a4 + 027c564 commit 0a3b3d1
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 13 deletions.
14 changes: 7 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ references:
- image: cimg/node:<< parameters.node-version >>-browsers
parameters:
node-version:
default: "16.14"
default: "18.16"
type: string

workspace_root: &workspace_root ~/project
Expand Down Expand Up @@ -143,14 +143,14 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ "16.14" ]
node-version: [ "16.14", "18.16" ]
- test:
requires:
- build-v<< matrix.node-version >>
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ "16.14" ]
node-version: [ "16.14", "18.16" ]

build-test-publish:
when:
Expand All @@ -165,7 +165,7 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ "16.14" ]
node-version: [ "16.14", "18.16" ]
- test:
filters:
<<: *filters_version_tag
Expand All @@ -174,7 +174,7 @@ workflows:
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ "16.14" ]
node-version: [ "16.14", "18.16" ]
- publish:
context: npm-publish-token
filters:
Expand All @@ -197,12 +197,12 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ "16.14" ]
node-version: [ "16.14", "18.16" ]
- test:
requires:
- build-v<< matrix.node-version >>
context: next-nightly-build
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ "16.14" ]
node-version: [ "16.14", "18.16" ]
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"snyk": "^1.168.0"
},
"engines": {
"node": "16.x",
"npm": "7.x || 8.x"
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
},
"husky": {
"hooks": {
Expand All @@ -52,7 +52,6 @@
}
},
"volta": {
"node": "16.14.1",
"npm": "7.20.2"
"node": "18.16.0"
}
}

0 comments on commit 0a3b3d1

Please sign in to comment.