-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework rendering API to allow for simultaneous "human" and "rgb_array" mode rendering #1010
Comments
While, it is not standard, I don't see why |
An alternate solution would be to to allow multiple render modes at the same time Example: Note: this has been previously suggested inhttps://github.com/openai/gym/issues/3038 |
I see three issues with the way rendering is currently implemented:
I feel like this would overcomplicate things, as certain combinations don't really make sense (e.g., combining "rgb_array" and "rgb_array_list". Also, the render functions would have to be rewritten so that they return multiple different renderings, e.g., "ansi" and "rgb_array". All that I would like to have is being able to enable human rendering next to other rendering modes. |
There is a point in letting the HumanRender be transparent, as it actually is not possible to observe/verify what is rendered. |
Proposal
I propose to change the gym environment API so that human and rgb_array rendering can be enabled/disabled independently. Hence, instead of having to choose just between no rendering, "human" rendering, and "rgb_rendering", there should be another option to enable both.
Motivation
One thing that has always bothered me about gym is that there is no way of rendering environments in "rgb_array" mode, while also displaying their "human" visualization. However, there are valid use-cases for doing this, e.g., if the policy expects a rendered image as input, but one also wants to see what is currently happening in the scene.
Additionally, when using a simulator like PyBullet or IsaacSim in gym environments, the simulator already provides an interface, which simply has to be enabled at the start. The interfaces these simulators provide are interactive and are thus much more informative for the user than the static "rgb_array" outputs. However, currently, one has to choose between seeing the interfaces and rendering numpy images.
In my opinion, there is no reason why the rendering modes should be mutually exclusive.
Pitch
This could be implemented by separating the "human" rendering mode from the
rendering_mode
variable. Hence, one could add a boolean option,human_rendering
, which enables or disables "human" rendering mode. If enabled, human rendering is always performed in thestep
function (I think this is already the case).The
render
function specification changes so that it is no longer allowed to returnNone
. Instead, it should throw an exception if it is called without any rendering mode active and else return the rendered image in the specified format.Alternatives
A workaround is to write a wrapper that takes "rgb_array" images generated by
gym.Env.render
and displays them as well as returning them in its ownrender
function. For custom environments using simulators like PyBullet and IsaacSim, a custom option can be implemented to display their interfaces even if the rendering mode is not set tohuman
.Additional context
No response
Checklist
The text was updated successfully, but these errors were encountered: