Fix some quadratic name lookup behavior #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LukeXuan reported that in files with a large number of top-level definitions, typechecking becomes quadratic.
One reason for this is because (surprisingly) we were resolving top-level names in a list (env.gamma_sig) even though we also have a hash map for lookups. Removing this linear scan eliminates one source of the quadratic behavior. I just removed the lookup in gamma_sig.
I also fixed a couple of quadratic list concatenations in SMTEncoding.Encode, though as @mtzguido pointed out, switching systematically to catenable lists will be better.