Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing smurf protection results in login loop #1062

Open
samuel-hxs opened this issue Jul 12, 2018 · 1 comment
Open

Missing smurf protection results in login loop #1062

samuel-hxs opened this issue Jul 12, 2018 · 1 comment

Comments

@samuel-hxs
Copy link

I experienced... write here what happened to you or what the current behaviour is.
Starting FAF from Pycharm on Linux.
Using a clean setup no privous data.
Popup with error message of missing uid.
Accepting leads to login screen.
Trying to login leads to missing uid message.
Repeat.

how to reproduce if explanation is needed to reproduce the problem, add it here
Forgot to add UID to PATH.

I expected... write here what you think the best behaviour should be
One error message and and switching to offline mode.

Where the bug is / What should be done if you have a suggestion for fixing the issue, add it here.
Stopping the loop or giby giving error message that login withou uid is not possibly.

@Wesmania
Copy link
Contributor

send_login function from _clientwindow.py governs uid generation. We should disable lobby_reconnector and terminate lobby connection in functions that call it if it returns false, instead of showing the login widget.
In general we should distinguish login failures caused by incorrect login from failures caused by other problems, and only show the login window again in the latter case.

(On the same note - we should make it more obvious how to open the login window again, right now you have to right-click the icon in top left.)
(On another note - we need to finally move all login-related code outside _clientwindow.py.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants